Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r_drawdecals 0 still displays decals on Displacements #879

Closed
Ninja-Cookie opened this issue Aug 3, 2020 · 6 comments
Closed

r_drawdecals 0 still displays decals on Displacements #879

Ninja-Cookie opened this issue Aug 3, 2020 · 6 comments
Assignees
@Gocnak
Labels
Outcome: Resolved This was resolved, and will be in a future update. Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.
Projects
0.9.0 Release

Comments

@Ninja-Cookie
Copy link

r_drawdecals 0 does stop drawing decals on normal surfaces, such as rocket explosion decals, but seems to still draw them on Displacements.
@Ninja-Cookie Ninja-Cookie added the Type: Bug Something that should work/look one way isn't quite doing that. label Aug 3, 2020
@Gocnak Gocnak added the Where: Engine This is something that will be done in the base engine. label Aug 6, 2020
@Gocnak Gocnak added this to To Do in 0.9.0 Release via automation Apr 9, 2021
@Gocnak Gocnak self-assigned this Apr 11, 2021
@Gocnak Gocnak added the Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" label Apr 11, 2021
@Gocnak Gocnak moved this from To Do to In Progress in 0.9.0 Release Apr 11, 2021
@Gocnak Gocnak added the Blocked: Needs testing & verification Needs testing and verification if properly fixed. label Apr 11, 2021
@lvaness
Copy link
Member

lvaness commented Apr 11, 2021

This is definitely still happening, they still draw on displacements and props.

@Gocnak
Copy link
Member

Gocnak commented Apr 11, 2021

Yep this should be fixed for the next (0.8.8 release) push. The only thing that respected it was brushes, it's now been updated to disable decals on props, displacements, and other models.

@lvaness
Copy link
Member

lvaness commented Apr 17, 2021

Now, it only still draws on dynamic props when it's set to 0.

@Gocnak
Copy link
Member

Gocnak commented Apr 19, 2021

Good catch, that is also fixed in the next push.

@lvaness
Copy link
Member

lvaness commented May 1, 2021

Looks fixed

@Arkanoid0
Copy link
Contributor

fix is good

@Gocnak Gocnak added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels May 1, 2021
@Gocnak Gocnak closed this as completed May 1, 2021
0.9.0 Release automation moved this from In Progress to Done May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gocnak Gocnak

Labels
Outcome: Resolved This was resolved, and will be in a future update. Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.
Projects
No open projects
0.9.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Arkanoid0 @Gocnak @lvaness @Ninja-Cookie