Track Student Graduation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the student-list and add-attendance-event-list to show the student's graduation year if the student's name appears in the list more than once.
Only navigate to student details if we're not in edit mode. Otherwise, check/uncheck the clicked student.
CombineLatest(allStudents, controls) was causing the repetition because both were replaysubjects. So whenever allStudents was updated, combineLatest would get (new allStudents, old controls) followed immediately by (new allStudents, new controls). The solution is to just include the allStudents in the controls subject, so that both come through at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55