Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds correct filter translations for the UBVRI filters for the NOT. In addition, the (previously incorrect) observatory code is fixed.
I also note that ALFOSC/FASU has multiple filter wheels, each with its own individual keyword. The UBVRI filters are always in ALFLTNM (which telescopes.py currently checks) but e.g. the SDSS filters are usually found in FAFLTNM. This PR doesn't do anything about that as I'm unsure on how you'd want to handle that properly.