CID/CIA translation in generateImpactsAppreciation

[b4stet]

zm-client/src/MonarcFO/Service/DeliverableGenerationService.php

Line 1469 in a905e04

$table->addCell(\PhpOffice\Common\Font::centimeterSizeToTwips(1.00), $cellRowSpan)->addText(ucfirst($impact), $styleContentFontBold, $alignCenter);

Hi,
The mentioned method is used to generate deliverable #2 Context Modelling.
At this line, ucfirst($impact) may need to be translated, otherwise every languages will get 'D' for availability in the table.

If you confirm, I tested and one solution to get CID/CIA accordingly is to replace L1469 by:

$translatedImpact = ucfirst($impact);
if ($impact === 'd'){
     $translatedImpact = ucfirst($this->anrTranslate('A'));
}
$table->addCell(\PhpOffice\Common\Font::centimeterSizeToTwips(1.00), $cellRowSpan)->addText($translatedImpact, $styleContentFontBold, $alignCenter);

[cedricbonhomme]

Nice catch, this will indeed fix the problem.
Feel free to make a PR. Or if you prefer I can commit this.
Thank you