Small refactorings to make code more pythonic

[LucaCappelletti94]

No description provided.

[LucaCappelletti94]

I get a couple of errors from Travis which does not seem related to my commits, I think a couple of files are missing: TypeError: Could not find graph file data/ppismall/pos_train_edges and TypeError: Could not find graph file data/ppismall/pos_train_edges.

[callahantiff]

@LucaCappelletti94 - Sorry you are getting an error! This file has definitely had some significant changes made to it on the creating_keras_develop_branch branch, which has not yet been merged with other branches. Our thought being to make one giant PR from this branch when we had finished the full tf refactor. I'm now wondering if it might be worth it to make a branch of creating_keras_develop_branch and push some of the intermediate changes to files that are not dependent on the tf refactor.

What do you think about this? Sorry for the headache caused by these errors!

[justaddcoffee]

@LucaCappelletti94 I think this should fix the problematic test here

[justaddcoffee]

@LucaCappelletti94 I changed the base to develop (from master) - since generally we want to merge into develop

if there are no objections, it would also be helpful to make PRs from named branches (e.g. my_awesome_pr) on https://github.com/monarch-initiative/N2V instead of our individual forks of N2V (not strictly necessary though)

[callahantiff]

@justaddcoffee - what did you think about my comment above?

[justaddcoffee]

@justaddcoffee - what did you think about my comment above?

Could we chat about how to do this? Possibly could just cherry-pick some commits from creating_keras_develop_branch into develop. Or possibly it might be simplest to just finish the tf refactor as soon as possible and then deal with all the differences between these two branches.

[callahantiff]

@justaddcoffee - what did you think about my comment above?

Could we chat about how to do this? Possibly could just cherry-pick some commits from creating_keras_develop_branch into develop. Or possibly it might be simplest to just finish the tf refactor as soon as possible and then deal with all the differences between these two branches.

Happy to do whatever is easiest, just thought it was worth mentioning. Either way, I'm happy to approve this PR once the merge conflicts are resolved.

[callahantiff]

Sorry, I should have done this sooner. Looks fine to me (minus merge conflicts)!

[justaddcoffee]

This is going to be hard to merge since it's based on master not develop - without any objection, I'm going to make a new PR for this and put Luca's nice improvements in that