Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to download most recent log file #45

Closed
wants to merge 114 commits into from

Conversation

emilytrau
Copy link

Description

Adds a button to the Download Files page to download the most recent log file.

Do not merge until React branch (#44) is merged

Screenshots

image

Steps to Test

Start dev server according to README and go to http://localhost:3000/download-files.

@emilytrau emilytrau self-assigned this Jan 13, 2020
@hallgchris
Copy link
Member

Really cool to see how a normal feature PR would look with React! (it looks great)

Also, the feature is a great idea

@khanguslee khanguslee added the Blocked PR blocked by something label Jan 16, 2020
@emilytrau emilytrau removed the Blocked PR blocked by something label Jan 20, 2020
@emilytrau emilytrau changed the base branch from react to master January 20, 2020 23:30
@emilytrau
Copy link
Author

Squashing the react branch has completely broken this PR. I'm going to resubmit it.

@emilytrau emilytrau closed this Jan 20, 2020
@khanguslee
Copy link
Contributor

Delete branch?

@emilytrau emilytrau deleted the angustrau/download_recent_log branch January 25, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants