Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mock wireless module test script #30

Merged
merged 37 commits into from Jan 14, 2020
Merged

Conversation

@Blake-Haydon
Copy link
Contributor

Blake-Haydon commented Jan 9, 2020

No description provided.

Copy link
Member

khanguslee left a comment

Good work on your first PR!!! There's quite a few changes to make since the PR is pretty long since I got you after you were done. Usually, we like to keep the PR smaller so you don't need to make as much changes and it takes less time for people to review too! Let me know if you have any questions!

I would read https://github.com/monash-human-power/BOOST/blob/master/mqtt_max_speed.py to help you with bunching up the argparse stuff

Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
@khanguslee

This comment has been minimized.

Copy link
Member

khanguslee commented Jan 9, 2020

Also, feel free to add the whole of software team to be reviewers of this PR!

@khanguslee khanguslee requested review from angustrau, hallgchris and maanika Jan 9, 2020
@khanguslee

This comment has been minimized.

Copy link
Member

khanguslee commented Jan 9, 2020

When you submit a PR, your PR should also include a description of what the changes were, how to test it and expected results.

Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
@Blake-Haydon Blake-Haydon changed the title Mock wireless sensor test script Blake-Haydon/mock-wireless-sensor Jan 10, 2020
@khanguslee khanguslee added the WIP label Jan 10, 2020
Copy link
Member

hallgchris left a comment

Will continue review on new files (GitHub got upset cos the code was all moved around)

Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/MockSensor.py Outdated Show resolved Hide resolved
Raspi/Test/MockSensor.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Copy link
Member

angustrau left a comment

Looks good 👍

Copy link
Member

hallgchris left a comment

Looking great! Sorry for the long review haha

Copy link
Member

khanguslee left a comment

Some small stuff that I didn't pick up before oops.

Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
Raspi/Test/mock_wireless_module.py Outdated Show resolved Hide resolved
c02 was changed to co2 which is what it is meant to be. GPS was also changed to lowercase to match the formating guide
@Blake-Haydon Blake-Haydon dismissed stale reviews from hallgchris and angustrau via b991f10 Jan 14, 2020
@Blake-Haydon Blake-Haydon requested a review from khanguslee Jan 14, 2020
Copy link
Member

khanguslee left a comment

Good work! Thanks for all the changes! Hopefully now you know a little bit more about PRs and Python! 👍

@Blake-Haydon Blake-Haydon merged commit e7a1317 into master Jan 14, 2020
1 check failed
1 check failed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
@Blake-Haydon Blake-Haydon deleted the Mock-wireless-sensor branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.