Create mock wireless module test script #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanguslee
suggested changes
Jan 9, 2020
There was a problem hiding this comment.
Good work on your first PR!!! There's quite a few changes to make since the PR is pretty long since I got you after you were done. Usually, we like to keep the PR smaller so you don't need to make as much changes and it takes less time for people to review too! Let me know if you have any questions!
I would read https://github.com/monash-human-power/BOOST/blob/master/mqtt_max_speed.py to help you with bunching up the argparse stuff
|
Also, feel free to add the whole of software team to be reviewers of this PR! |
|
When you submit a PR, your PR should also include a description of what the changes were, how to test it and expected results. |
emilytrau
suggested changes
Jan 9, 2020
Blake-Haydon
changed the title
hallgchris
requested changes
Jan 10, 2020
hallgchris
requested changes
Jan 10, 2020
emilytrau
previously approved these changes
Jan 10, 2020
Blake-Haydon
changed the title
'Either a single val that sets the average value for the sensor or and array of subvals' was changed to 'Either a single val that sets the average value for the sensor or an array of subvals'
hallgchris
previously approved these changes
Jan 13, 2020
khanguslee
suggested changes
Jan 13, 2020
c02 was changed to co2 which is what it is meant to be. GPS was also changed to lowercase to match the formating guide
Blake-Haydon
dismissed stale reviews from hallgchris and emilytrau
via
b991f10
khanguslee
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.