Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack of weekend fixes #18

Merged
merged 8 commits into from
Jan 9, 2023
Merged

Stack of weekend fixes #18

merged 8 commits into from
Jan 9, 2023

Conversation

silasdavis
Copy link

This PR:

  • Fixes overflows when handling BigNumbers
  • Adds support for some older features
  • Refactors the agreement feature
  • Introduces some compile-time helpers for handling groups of features
  • Adds a stub integration test
  • Fixes some code generation issues
  • Fixes some issues in react app and enables tsc strict mode there
  • Switches from yarn to pnpm

Silas Davis added 7 commits January 7, 2023 16:48
Fix number handling and add test contract
0e91973 
Also add stub integration test for collection contract

Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Fix Agreement feature for some older contracts
1721974 
Also introduce partitioner tool to help spot at compile time if we are
not handling features we intend to.

Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Update features docs
6ddb098 
Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Use strict mode for React app
eb96ed3 
Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Combine CI build and test
7d7858d 
Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Switch to pnpm
26eee12 
Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
Make generated code path-dependent so as to not alias types
435e3b8 
Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
@silasdavis silasdavis mentioned this pull request Jan 9, 2023
Closed
danielz-mnx
danielz-mnx reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@danielz-mnx danielz-mnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set comments.
@silasdavis you've done wonders!!!

sdk/package.json Outdated Show resolved Hide resolved
sdk/src/contracts/collections/features.test.ts Show resolved Hide resolved
Switch to pnpm
176f824 
- Faster builds
- Fixes transitive dependency issue in react app
- Way less hassle with monorepo builds

Signed-off-by: Silas Davis <silas.davis@monaxlabs.io>
@silasdavis silasdavis mentioned this pull request Jan 9, 2023
Merged
@danielz-mnx danielz-mnx merged commit 4675bb2 into main Jan 9, 2023
@silasdavis silasdavis deleted the pnpm branch January 9, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielz-mnx danielz-mnx danielz-mnx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silasdavis @danielz-mnx