Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secret key should not be derived at runtime #85

Merged
merged 1 commit into from
Dec 12, 2019
Merged

secret key should not be derived at runtime #85

merged 1 commit into from
Dec 12, 2019

Conversation

gregdhill
Copy link
Contributor

also prevents chunksize 0 and allows reading symmetric keys from environment

Signed-off-by: Gregory Hill greg.hill@monax.io

@gregdhill gregdhill force-pushed the mv-derivesecretkey branch 3 times, most recently from 16ccbc3 to b197e19 Compare December 12, 2019 13:41
silasdavis
silasdavis requested changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@silasdavis silasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments could be a little clearer - a bit too much how and not enough why - but otherwise LGTM

grant/symmetric.go Show resolved Hide resolved
grant/symmetric.go Show resolved Hide resolved
secret key should not be derived at runtime to avoid high memory cons…
c1b7da4 
…umption

Signed-off-by: Gregory Hill <greg.hill@monax.io>
@gregdhill gregdhill merged commit effc361 into monax:master Dec 12, 2019
@gregdhill gregdhill deleted the mv-derivesecretkey branch December 12, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silasdavis silasdavis silasdavis requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregdhill @silasdavis