typescriptify hoard #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
typescript
branch
5 times, most recently
from
06f5060
to
b0b7a7c
Compare
gregdhill
force-pushed
the
typescript
branch
2 times, most recently
from
fa09095
to
5027ef0
Compare
gregdhill
force-pushed
the
typescript
branch
from
6112d8e
to
54be757
Compare
gregdhill
force-pushed
the
typescript
branch
from
54be757
to
8b77009
Compare
silasdavis
reviewed
Feb 21, 2020
| // Reads from the provided byteStream until a varint length-prefixed prefix of the stream can be returned. | ||
| // The stream will be destroyed once the prefix has been read so will not be totally consumed | ||
| export async function ReadLengthPrefixed(stream: Readable, byteLength: number): Promise<Buffer> { | ||
| let buffer = Buffer.alloc(0); |
There was a problem hiding this comment.
Are we still using this?
There was a problem hiding this comment.
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
typescript
branch
from
8b77009
to
7548b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill greg.hill@monax.io
https://github.com/improbable-eng/ts-protoc-gen