Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to connect via ssh to a remote docker node. #143

Merged
merged 2 commits into from Oct 30, 2021
Merged

Add the possibility to connect via ssh to a remote docker node. #143

merged 2 commits into from Oct 30, 2021

Conversation

tbocek
Copy link
Contributor

@tbocek tbocek commented Oct 22, 2021

This PR also upgrades to the latest github.com/docker/docker where a custom client.WithDialContext can be set (docker/go-connections does not support it). This makes it possible to use dry with: dry -H ssh://user@ip:22/var/run/docker.sock

…s also upgrades to the latest github.com/docker/docker where a custom client.WithDialContext can be set (docker/go-connections does not support it)
@moncho
Copy link
Owner

moncho commented Oct 23, 2021

Pretty awesome, @tbocek!! Thanks a lot for the PR.

Checks are failing, the TravisCI one because it was using an old go version but the GH action is failing because of a test that is not passing: https://github.com/moncho/dry/runs/3985165788#step:4. Could you please take a look at it?

Also, it would be good if you could rebase master onto your branch to fix the problem with the TravisCI build.

@tbocek
Copy link
Contributor Author

tbocek commented Oct 25, 2021

Oops, I thought my changes were not that invasive, but I'm using the latest docker dependency and the docker interfaces changed a bit.

@tbocek
Copy link
Contributor Author

tbocek commented Oct 25, 2021

Hmm, I did not rebase, but the problem seems to be with linting, however, the output says:

golangci-lint found no issues
Ran golangci-lint in 11725ms the GH action

I also tried to check with golangci-lint 1.42.1, and this shows up with many errors.

Copy link
Owner

@moncho moncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moncho moncho merged commit 001b450 into moncho:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants