Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM architecture as a case statement #66

Merged
merged 3 commits into from May 3, 2018
Merged

ARM architecture as a case statement #66

merged 3 commits into from May 3, 2018

Conversation

pekovac
Copy link
Contributor

@pekovac pekovac commented Apr 27, 2018

On different systems _isarm=$(echo $_cputype|awk '{print substr($0,0,4)}') provides a different results, on RPi it's working with expected results, but on Odroid-XU4 the output is armv which is not matched in current version of the script, thus resulting in error:

Debian 8 Odroid-XU4

# uname -a
Linux nas 4.9.61-odroidxu4 #2 SMP PREEMPT Wed Nov 22 16:34:23 CET 2017 armv7l GNU/Linux
# curl -sSf https://moncho.github.io/dry/dryup.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    10  100    10    0     0     33      0 --:--:-- --:--:-- --:--:--    33
armv
sh: 233: CFG_CPUTYPE: parameter not set

Raspberry Pi

# uname -a
Linux retropie 4.9.26v7-aufs #1 SMP Tue May 9 20:14:03 CEST 2017 armv7l GNU/Linux
# curl -sSf https://moncho.github.io/dry/dryup.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    10  100    10    0     0     38      0 --:--:-- --:--:-- --:--:--    38
dryup: downloading dry binary
######################################################################## 100.0%
dryup: Moving dry binary to its destination
dryup: dry binary was copied to /usr/local/bin, now you should 'sudo chmod 755 /usr/local/bin/dry'

Copy link
Owner

@moncho moncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!!!

Would you mind fixing the indentation of the new case statement? Other than that, the change LGTM.

@pekovac
Copy link
Contributor Author

pekovac commented May 2, 2018

@moncho indentation fixed as requested.

@moncho moncho merged commit b9c0637 into moncho:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants