[Bug] monday.storage.instance.setItem(someKey, someVal) silently fails when someVal contains a newline character

[dvdsmpsn]

Describe the bug

monday.storage.instance.setItem(someKey, someVal) silently fails when someVal contains a newline character

Steps to reproduce

1. Embed the SDK in an app
2. Call monday.storage.instance.setItem(someKey, someVal) where someVal has a newline character
3. The request silently fails

Example 1: Expected behavior

Without a newline character, everything is fine.

const monday = mondaySdk();

const someKey = "someKey";
const someVal = "Lorem Ipsum 123";
monday.storage.instance.setItem(someKey, someVal).then((res) => {
  console.log(res);
  // --> {method: 'storage', type: undefined, data: {success: true, version: 'edc92'}, requestId: 'en3u9u96f', errorMessage: undefined}
  
  monday.storage.instance.getItem(someKey).then((res) => {
    console.log(res.data.value); 
    // --> Lorem Ipsum 123
    
  });
});

Example 2: Actual behavior with new line character

This now fails silently because of a new line character, but reports that it has succeeded.

const monday = mondaySdk();

const someKey = "someKey";
const someVal = "Lorem Ipsum 123\n\nxxxx";
monday.storage.instance.setItem(someKey, someVal).then((res) => {
  console.log(res);
  // --> {method: 'storage', type: undefined, data: {success: true, version: 'edc92'}, requestId: 'en3u9u96f', errorMessage: undefined}
  
  monday.storage.instance.getItem(someKey).then((res) => {
    console.log(res.data.value); // --> NULL
  });
});

Example 3: A workaround

Dodgy workaround to get around the failure from the new line character

const monday = mondaySdk();
const someKey = "someKey";
const someVal = "Lorem Ipsum 123\n\nxxxx";
const newLine = "[NEWLINE]";
monday.storage.instance.setItem(
  someKey, 
  someVal.replaceAll("\n", newLine)
).then((res) => {
  console.log(res);
  // --> {method: 'storage', type: undefined, data: {success: true, version: 'edc92'}, requestId: 'en3u9u96f', errorMessage: undefined}
  
  monday.storage.instance.getItem(someKey).then((res) => {
    console.log(
      res.data.value
    ); // --> Lorem Ipsum 123[NEWLINE][NEWLINE]xxxx
    
    console.log(
      res.data.value
        .replaceAll(newLine, "\n")
    ); // --> Lorem Ipsum 123\n\nxxxx
  });
});

Context and environment
What capabilities were you trying to use?
-monday.storage.instance.setItem(someKey, someVal) where someVal has a newline character

On which browser/mobile device?

• any desktop browser

What app was involved?

• my own developer app

Additional information

• More info

[gregra81]

Hey @dvdsmpsn, I know this is coming almost two years later, but I'm doing some hygiene in these issues. From checking with the team, this issue has already been resolved, so I'm closing it for now. If you have a new issue around the storage methods, feel free to open a new issue