chore: fix hooks related eslint issues (#134)

mondaycom · Dec 26, 2023 · 5daed08 · 5daed08
1 parent e5a6216
commit 5daed08
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/components/github-contributors-list/github-contributors-list.tsx b/src/components/github-contributors-list/github-contributors-list.tsx
@@ -24,7 +24,7 @@ const GithubContributorsList: FC<GithubContributorsListProps> = ({
   const [contributorsJson, setContributorsJson] = useState<GithubContributorResponse[]>([]);
   useEffect(() => {
     fetchAllContributors(organizationName, packageName).then(contributors => setContributorsJson(contributors));
-  }, []);
+  }, [organizationName, packageName]);
 
   const contributors = useMemo(() => {
     const developerContributors = contributorsJson
@@ -42,7 +42,7 @@ const GithubContributorsList: FC<GithubContributorsListProps> = ({
       );
     const contributorsData = staticContributors.concat(developerContributors);
     return <ContributorsList contributorsData={contributorsData} showContributionAmount={showContributionAmount} />;
-  }, [contributorsJson]);
+  }, [contributorsJson, excludedContributorsIds, showContributionAmount, staticContributors]);
 
   return (
     <Paragraph>

diff --git a/src/components/related-component/related-component.tsx b/src/components/related-component/related-component.tsx
@@ -20,7 +20,8 @@ const RelatedComponent: React.FC<RelatedComponentProps> & { linkTargets?: typeof
   href,
   linkTarget,
 }) => {
-  const overrideLinkTarget = linkTarget || useContext(RelatedComponentsContext).linkTarget;
+  const contextLinkTarget = useContext(RelatedComponentsContext)?.linkTarget;
+  const overrideLinkTarget = linkTarget || contextLinkTarget;
   return (
     <InformationBox
       component={<div className={styles.relatedComponentComponent}>{component}</div>}

diff --git a/src/components/storybook-link/storybook-link.tsx b/src/components/storybook-link/storybook-link.tsx
@@ -20,7 +20,7 @@ const StorybookLink: FC<StorybookLinkProps> & { sizes?: typeof LinkSize } = ({ p
       const href = await hrefTo(page, story);
       setUrl(href);
     }
-  }, []);
+  }, [page, story]);
 
   return (
     <Link href={url} target={Link.targets.TOP} withoutSpacing size={size}>