Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttentionBox: Change the role of the component to alert instead of complementary #256

Closed
hadasfa opened this issue Oct 11, 2021 · 7 comments
Assignees
Labels
bug Something isn't working hacktoberfest

Comments

@hadasfa
Copy link
Contributor

hadasfa commented Oct 11, 2021

AttentionBox: Change the role of the "AttentionBox" component to alert instead of complementary.

@hadasfa hadasfa added bug Something isn't working hacktoberfest accessibility labels Oct 11, 2021
@Mihir50
Copy link
Contributor

Mihir50 commented Oct 11, 2021

Hey! I am pretty new to open source and I have never contributed to such a huge codebase. Can you please help me out here?

const role = useMemo(() => {
    if (type === ATTENTION_BOX_TYPES.DANGER) {
      return "alert";
    }

    return "complementary";
  }, [type]);

Should I remove the if statement and directly return alert?

@Dev5902
Copy link
Contributor

Dev5902 commented Oct 12, 2021

@hadasfa can you assign me this issue

@Mihir50
Copy link
Contributor

Mihir50 commented Oct 12, 2021

@hadasfa can you assign me this issue

Hey I was working on this :(

@Dev5902
Copy link
Contributor

Dev5902 commented Oct 12, 2021

@Mihir50 I am also new to open source but I know that until and unless an issue is not assigned to anyone it can be worked upon by anyone who wants to work on it. I am very close to solving this issue.

@Dev5902
Copy link
Contributor

Dev5902 commented Oct 13, 2021

@hadasfa can you please review the PR and merge it if it is all ok.

@hadasfa
Copy link
Contributor Author

hadasfa commented Oct 13, 2021

@Dev5902 Thank you so much for your contribution! The PR is great, there is only one small thing I need to check regarding the change. I will update by Sunday.

@hadasfa
Copy link
Contributor Author

hadasfa commented Oct 14, 2021

solved by @Dev5902 #262

@hadasfa hadasfa closed this as completed Oct 14, 2021
talkor added a commit that referenced this issue Feb 13, 2024
* feat(mixins): export mixins

* refactor: remove redundant mixins

* docs: restructure mixins list in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants