-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for urls in include markdown tag #159
Conversation
Can I get a review on this PR please? |
Can someone review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the attempt and sorry for the delay.
…_file_to_include. Also repaired read_http function to get the target_url and to decode
@mondeja ready for your review |
@mondeja can you review? I would like to get this into production. Thank you |
@mondeja can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll continue the implementation and release a new version ASAP.
I avoid registering the url to the file watcher so that "mkdocs serve" works fine, and mkdocs build also works. If an external url's content changes, then you would need to regenerate your docs.