Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow subscription id to be specified #29

Merged
merged 3 commits into from
Jul 2, 2016
Merged

Conversation

furkanmustafa
Copy link

In our use case, we wanted to be able to specify subscription id.

I've added an optional third id option to sub method.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 542c954 on the-shell-inc:master into a0d0083 on mondora:master.

@pscanf
Copy link
Member

pscanf commented Jul 2, 2016

Thanks for the PR! Could you add a test for the case? Otherwise LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 48d8408 on the-shell-inc:master into a0d0083 on mondora:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ff0098b on the-shell-inc:master into a0d0083 on mondora:master.

@pscanf pscanf merged commit 34ef53b into mondora:master Jul 2, 2016
@pscanf
Copy link
Member

pscanf commented Jul 2, 2016

Thanks! 👍

@furkanmustafa
Copy link
Author

thank you too for nice work!

@pscanf
Copy link
Member

pscanf commented Jul 2, 2016

I've published 2.2.0 with your change. Let me know if all works as expected. :-)

@furkanmustafa
Copy link
Author

thanks! worked very well :)

it needs an update on asteroid too. creating a pull request on asteroid in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants