New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm audit errors and convert to using Jest. #2
Open
michelnev
wants to merge
2
commits into
moneals:master
Choose a base branch
from
michelnev:jest-patch
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…536. Received whois.nic.do.' uncaught exception caused by regular express issue and uncaught exception when creating a socket.
Thanks for the PR. I run into issues when running npm test on your branch:
Unexpected token { |
Strange, it worked for me. Thanks, I'll take a look to see why that is and
retest everything.
…On Thu, Sep 10, 2020 at 2:23 PM Michael Smith ***@***.***> wrote:
Thanks for the PR. I run into issues when running npm test on your branch:
npx jest
Unexpected token {
npm ERR! Test failed. See above for more details.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLAEXWXWWYJVOFFE2BGASDSFERSXANCNFSM4Q65DNAA>
.
|
@moneals if you delete the node_modules directory and install, do you have any issues? Here's what I did in the forked repo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the packages used for testing to remove most audit concerns and, as a result, switches to Jest for testing.
NOTE: I'd suggesting using mocks instead of what is currently being done, but I left it as-is to get the audit issues addressed. This will also allow the test coverage to be more complete.