Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference implementations for various types of light sources #6

Closed
emackey opened this issue Mar 10, 2017 · 1 comment
Closed

Reference implementations for various types of light sources #6

emackey opened this issue Mar 10, 2017 · 1 comment

Comments

@emackey
Copy link
Collaborator

emackey commented Mar 10, 2017

Per comments in KhronosGroup/glTF#697, it would be great to establish reference code for a number of different types of light sources, used in various combinations and quantities.

This likely means that the lighting calculations won't be hard-coded, instead each type of light source will have some snippet of GLSL code that can be injected once per instance of that type.
@emackey
Copy link
Collaborator Author

emackey commented Jun 3, 2017

If anyone wants this, please open a new issue in the Khronos repo. Thanks!

@emackey emackey closed this as completed Jun 3, 2017
sbtron pushed a commit to sbtron/WebGL-PBR that referenced this issue Dec 19, 2018
@emackey
Merge pull request moneimne#6 from KhronosGroup/optional-srgb
ec09d0b 
Tolerate lack of sRGB extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emackey