Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Commit

Permalink
Refactoring backends submodule
Browse files Browse the repository at this point in the history
Motivation:
    `backends.jsonrpc` was already probably longer than it needed to be. I split
up the logic for `JSONRPCDaemon` and `JSONRPCWallet` in order to increase readibility.
This will be especially important in the future as more backends are written.
In particular, an issue (#73) is currently open which suggests adding MyMonero
API support. If this is added, it might be worth also adding the OpenMonero API.
Both of these are JSON RPC APIs, but I think it wouldn't necesarily make a lot
of sense to put these all into the same file so I went ahead and split the backends
up. Also, because of the default backends PR (#79), to the most basic of users, it
will matter much less how the backends are named, if you chose to take issue with
my naming. I hope this PR is useful for future development!

Changes:
    1. Moved `JSONRPCDaemon` to `backends.rpcdaemon`
    2. Moved `JSONRPCWallet` to `backends.rpcwallet`
    3. Moved `jsonrpc` exceptions to `backends.rpcexceptions`
    4. `monero.backends.jsonrpc` now only imports the backends and exceptions
    5. Edited test files accordingly

Notes:
    * This change is backwards compatible
  • Loading branch information
Jeffrey Ryan committed Jan 19, 2021
1 parent 91a533e commit a8c840a
Show file tree
Hide file tree
Showing 6 changed files with 568 additions and 556 deletions.

0 comments on commit a8c840a

Please sign in to comment.