Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Added get_tx_metadata when transaction is not relayed #124

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

euri10
Copy link

@euri10 euri10 commented Oct 4, 2022

Fixes #123

@euri10
Copy link
Author

euri10 commented Oct 4, 2022

question is should I do the same modification to the sweep_all mehtod ?

edit: I did

@euri10 euri10 marked this pull request as draft October 4, 2022 05:07
@euri10 euri10 marked this pull request as ready for review October 4, 2022 06:22
@euri10
Copy link
Author

euri10 commented Oct 4, 2022

the changes I made impact the transfer and sweep_all methods, and as the test_sweep_all uses relay=False it's a goog opportunity to get those changes tested, so the json test_sweep_all-20-sweep_all.json need to have a "tx_metadata_list" added.

@emesik I'd need a little guidance on how you generate the json files used in the tests so I can modify it so that test_sweep_all uses passes, it currently fails and righly so

@xmrluvr45
Copy link

xmrluvr45 commented Apr 8, 2023

works for me, this patch allows to check tx fee before using the relay_tx method to relay the transaction metadata hex.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relay transfer
2 participants