Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_transfers doesn't work as expected when minimum (and possibly maximum) block height is specified #111

Open
mrmena opened this issue Feb 25, 2020 · 1 comment

Comments

@mrmena
Copy link

mrmena commented Feb 25, 2020

The wallet RPC documentation allows for filtering of transfers by block height. The monerophp get_transfers method has the optional $min_height and $max_height parameters but they don't work unless the filter_by_height parameter is also set, which it isn't

@mrmena
Copy link
Author

mrmena commented Feb 25, 2020

After some digging, it looks like if you don't explicitly set the $max_height parameter to something less than the max (4206931337), the filter_by_height parameter doesn't get set.

Relevant source line:

if (($min_height || $max_height) && $max_height != 4206931337) {
    $params['filter_by_height'] = true;
}

Shouldn't I be able to filter by only setting the minimum block height?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant