Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

HTTP Proxy / AddressBook: ensure that jump service doesn't save already-known addresses #814

Closed
anonimal opened this issue Feb 21, 2018 · 1 comment · Fixed by #835
Closed

Comments

@anonimal
Copy link
Collaborator


By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

i.e., the address exists in addressbook but our jump service handler blindly writes to disk regardless. This issue is about disk handling and not in-memory addresses (we use a map to store in-memory addresses and access/set the elements via operator[]).

This may as well be an addressbook issue because not allowing dups should be an addressbook responsibility. TBD. Referencing #305.

@coneiric
Copy link
Contributor

This may as well be an addressbook issue because not allowing dups should be an addressbook responsibility.

Was thinking along similar lines, putting the check in AddressBookStorage::AddAddress and AddressBook::InsertAddressIntoStorage.

Going to start work on a PR for some address book TODOs related to #305, and will make this bug a priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants