This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Crypto: rewrite preexisting refactor. Fixes #164. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Redesign/refactor: the previous design was unnecessary in terms of organization and the logic was askew. Rewrite with maintainability in mind * Within the realm of Signature and ElGamal, refactor out the unfinished cryptopp * Finish the unfinished RNG-related refactor: - Swapout appropriate CryptoPP with Rand*-related calls - Creation of class DiffieHellman - Moving of CryptoConst into pimpl directory * Cleanup related files that still call cryptopp * C++11/style guideline refactor for touched files * Add Crypto++ CMake build option + related pimpl src dir handling * Various cleanups + add documentation
|
Build failed as I built tests before PR'ing but did not build benchmarks. Fix is on the way. |
|
Build passed. On that note, I am going to assign myself and finish #57 - and it could be done as soon as our next meeting (maybe earlier). |
anonimal
added a commit
that referenced
this pull request
Apr 15, 2016
anonimal
added a commit
to anonimal/kovri
that referenced
this pull request
Apr 20, 2016
In addition to the refactor:
* Separate crypto by use-case
- Crypto that's essential to core I2P network functionality stays in
./crypto
- Crypto that's not essential to core I2P network functionality goes
into ./crypto/util
- Library implementations go into ./crypto/pimpl
- Name/Re-name appropriate files
* Rewrite token generation implementation for I2PControl
* Minor design refactor of monero-project#170
* Minor guideline refactoring
* Adjust related CMake
* Add documentation
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
Place an X inside the bracket to confirm
organization and the logic was askew. Rewrite with maintainability in mind
SignatureandElGamal, refactor out the unfinishedcryptopp
Rand*-related callsDiffieHellmanCryptoConstinto pimpl directory