Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All translations need updates #1116

Closed
10 of 13 tasks
erciccione opened this issue Feb 14, 2018 · 21 comments
Closed
10 of 13 tasks

All translations need updates #1116

erciccione opened this issue Feb 14, 2018 · 21 comments

Comments

@erciccione
Copy link
Collaborator

erciccione commented Feb 14, 2018

After #1076 all translations of the GUI need to be updated. Some are already in progress, but many other need to be checked and updated before the next release.

These are the languages that aren't in porgress and need to be updated. I pinged in this issue all contributors who helped in past with the relative language, hoping they can contribute this time as well.

If you start working on a translation, please communicate it in the comments (if you have it, with the link to the WIP repository), so i can thick the relative language and consider it 'in progress'. Our tracking platform, Taiga, is costantly updated and a great place to check what languages are in progress and who is working on them.

If you need help/infos ask down here, PM me on reddit or come chat on #monero-translations

@ordtrogen
Copy link
Contributor

Just mentioning I'm hard at work on the Swedish one. As soon as I have a PR I'll make it known and anyone'll be welcome to comment.

@apertamono
Copy link
Contributor

OK, thanks for the reminder. I started updating the Dutch translation. It's ~100 new or edited strings.

@potatored Thanks for correcting some bad typos. If you have time to contribute translations, could you work on the Monero website?
@fridzema I see you're busy coding. Great!

@netrik182
Copy link
Contributor

The strings marked with <translation type="unfinished"> are ready to be translated or should we expect any changes in the english text before the release?

@erciccione
Copy link
Collaborator Author

@netrik182 they are ready to be translated, just take off the type="unfinished"> part and put your translation between <translation></translation>

@netrik182
Copy link
Contributor

@erciccione ok, thanks!

@apertamono
Copy link
Contributor

@netrik182 If you use Qt Linguist, it will take you automatically to the new and updated strings, and it will remove the 'unfinished' tag for you. It has other useful features too, like copying translations for repeated strings. Annoyingly, there's no official distribution other than the whole Qt package, but the download from Softpedia will probably be safe.

@netrik182
Copy link
Contributor

@ProkhorZ I'll take a look. Thank you

@mandrill-pie
Copy link
Contributor

Almost done with the Romanian translation. But here's a bit I'm having difficulties understanding:

Payment ID
A unique user name used in the address book.
It is not a transfer of information sent during the transfer.

What does that actually mean? Any other way to phrase it to help me translate it?

@mandrill-pie
Copy link
Contributor

Also, what's the next step when I'm done? A PR like last time?

@georgi-id
Copy link

I was wondering about that same passage @mandrill-pie. The last sentence especially doesn't sound good in english either.

@LvMsterfild
Copy link
Contributor

LvMsterfild commented Feb 19, 2018 via email

@mandrill-pie
Copy link
Contributor

@erciccione Romanian updated. I've opened a pull request #1125

@erciccione
Copy link
Collaborator Author

@LvMsterfild that PR was merged into the code, no need to link it directly

@mandrill-pie thanks! i'm gonna review it

@takuto-h
Copy link
Contributor

Hi, I've created a PR to update Japanese translation: #1132

@netrik182
Copy link
Contributor

@erciccione Just created PR for Brazilian Portuguese #1136

@cryptobench
Copy link
Contributor

PR submitted for danish translation #1142

@jonathancross
Copy link
Contributor

@mandrill-pie You are correct, this is bad English.

Should be something like:

Payment ID
An arbitrary, unique identifier used to distinguish payments.
The ID can be either 64 or 16 hexadecimal characters long.
If 16, it will be encrypted, if 64, it will be visible on the blockchain.
An ID can be combined with an address to form an Integrated Address.

Maybe best to fix the english and update all languages separately from this?

@Keksoj
Copy link
Contributor

Keksoj commented Apr 3, 2018

Hi, I'm the one who made the last translation fixes on the esperanto version. But if I check it at
https://github.com/monero-project/monero-gui/blob/master/translations/monero-core_eo.ts
I can't see any problem to it. Maybe I'm not looking good enough. Are they new lines to be added ?

Oh, okay, I just realised there's a bunch of

type="unfinished"

So, do I edit it, create a pull request and so on ? I'll have @erciccione help me for the details since I'm a bit of a noob.
You can count on me anyway !

@pazos
Copy link
Contributor

pazos commented Apr 3, 2018

@erciccione: can we switch translation upgrades to a platform like transifex or weblate? I think it would help contributors to get the work done.

@erciccione
Copy link
Collaborator Author

@pazos That's already in process. After the new release is out we will start working on the web platform. In our case, Pootle

@erciccione
Copy link
Collaborator Author

The new releaseis out!
Thanks everybody :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests