Use wallet2_api isAddressLocal utils method for isDaemonLocal check #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
approved these changes
Mar 7, 2018
moneromooo-monero
approved these changes
Mar 7, 2018
luigi1111
added a commit
that referenced
this pull request
Mar 13, 2018
da32161 Use wallet2_api isAddressLocal utils method for isDaemonLocal check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939 by using wallet2_api's
isAddressLocalmethod which confirms whether the address passed in is a local address or not. It callsis_local_addressinternally which the associated issue was referencing.I tested this by connecting to a remote node and confirmed that I saw the mining warnings that are not visible for local nodes. I also confirmed that when using the remote connect logic pointing to
localhostor127.0.0.1it was still treated as a local node from a warning perspective.(Note: if testing it looks like if you have a node up in the default port 18081 for mainnet or 28082 for testnet the remote node is ignored so I tested the local nodes treated as remote by running them on different ports)