Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer: hide PaymentId and Description by default #1855

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Transfer: hide PaymentId and Description by default #1855

merged 1 commit into from
Dec 26, 2018

Conversation

xiphon
Copy link
Collaborator

@xiphon xiphon commented Dec 21, 2018 •
edited
Loading

Requires #1853 #1854

Feedback and comments on proposed change are welcome.

transfer-hide-payment-id

@rbrunner7
Copy link
Contributor

Looks reasonable to me. A good compromise between slowly phasing out payment ids but still supporting them for the time being.

@selsta
Copy link
Collaborator

selsta commented Dec 21, 2018 •
edited
Loading

I like this feature but I’m unhappy about how “Payment IDs” is now not aligned with the other labels.

Maybe it’s possible to add the + to the left of the Payment ID label and align it like it was before.

@SamsungGalaxyPlayer
Copy link

SamsungGalaxyPlayer commented Dec 21, 2018 •
edited
Loading

We should go even further and say (optional, will be deprecated March/April 2019). See Monero issue 3772.

Of course, this is contingent on agreeing to remove them in the next upgrade.

@xiphon xiphon force-pushed the hide-payment-id branch 3 times, most recently from 9644ae5 to 8489763 Compare December 21, 2018 20:27
@xiphon
Copy link
Collaborator Author

xiphon commented Dec 21, 2018

Updated

selsta
selsta approved these changes Dec 21, 2018
View reviewed changes
Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! And thanks for the @2x graphics :)

@xiphon xiphon force-pushed the hide-payment-id branch 2 times, most recently from 3fff976 to e10e85a Compare December 22, 2018 00:37
@xiphon
Copy link
Collaborator Author

xiphon commented Dec 22, 2018

Updated to hide Description field too.

@xiphon xiphon changed the title Transfer: hide PaymentId by default Transfer: hide PaymentId and Description by default Dec 22, 2018
@dEBRUYNE-1
Copy link
Contributor

I'd remove the will be deprecated March/April 2019 part for now, as there's no consensus yet on when the long, unencrypted payment ID will be deprecated.

@xiphon
Copy link
Collaborator Author

xiphon commented Dec 24, 2018

I'd remove the will be deprecated March/April 2019 part for now, as there's no consensus yet on when the long, unencrypted payment ID will be deprecated.

Yep. Updated the PR.

@luigi1111 luigi1111 merged commit 55c3d07 into monero-project:master Dec 26, 2018
luigi1111 added a commit that referenced this pull request Dec 26, 2018
@luigi1111
Merge pull request #1855
b88ac2b 
55c3d07 Transfer: hide PaymentId and Description by default (xiphon)
@erciccione erciccione mentioned this pull request Dec 27, 2018
Closed
@xiphon xiphon deleted the hide-payment-id branch January 7, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta approved these changes

@mmbyday mmbyday mmbyday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xiphon @rbrunner7 @selsta @SamsungGalaxyPlayer @dEBRUYNE-1 @mmbyday @luigi1111