SimpleMode: automatic public nodes discovering and switching #2370
Conversation
xiphon
force-pushed
the
auto-public-nodes
branch
from
caa7cdc
to
2e73cdb
Compare
|
Line 97 in 3a9f0e1 |
Yep, but decided to keep it cause it's pretty common helper routine. |
xiphon
force-pushed
the
auto-public-nodes
branch
from
2e73cdb
to
fd11f8d
Compare
|
Updated. Dropped unused |
|
Closing the wallet in simple mode shows this, not sure if that’s related to this PR:
|
xiphon
force-pushed
the
auto-public-nodes
branch
from
fd11f8d
to
d4fb2c2
Compare
Could you provide reproduction steps? |
|
I would even reduce the initial delay time from 5 to like 2 seconds.
It shows up every time I exit the GUI in simple mode. |
xiphon
force-pushed
the
auto-public-nodes
branch
5 times, most recently
from
34468b0
to
7f1538e
Compare
|
Were you able to reproduce the |
Yep, the issue is not related to the PR |
xiphon
force-pushed
the
auto-public-nodes
branch
from
7f1538e
to
0d247a9
Compare
|
Squashed |
| middlePanel.settingsView.settingsStateViewState = "Wallet" | ||
| if (mode < 2) { | ||
| persistentSettings.useRemoteNode = false; | ||
| persistentSettings.bootstrapNodeAddress = "auto"; |
There was a problem hiding this comment.
When going back to advanced mode, persistentSettings.bootstrapNodeAddress stays at auto. Is this intended?
0d247a9 SimpleMode: automatic public nodes discovering and switching (xiphon)
Split the PR into two commits, suggest to review them separately since the first one is pretty straightforward stripping
https://autonode.xmr.pm/related code.Will squash the commits once the PR is approved