Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account: account page redesign #2925

Closed
wants to merge 8 commits into from
Closed

Account: account page redesign #2925

wants to merge 8 commits into from

Conversation

rating89us
Copy link
Contributor

@rating89us rating89us commented May 26, 2020 •
edited

Changes:

  • remove first address of each account (and copy to clipboard button): displaying a single address for each account incentivizes address reuse, discourages use of subaddresses, and gives a false idea that each account has an "official" or "main" address
  • remove "Balance:" label
  • account balances always visible, even with small window width
  • add XMR to balances
  • align balances
  • selected account now has highlighted background color

Before:
image

After:
accountselect

@rating89us rating89us mentioned this pull request May 27, 2020
Closed
@rating89us rating89us marked this pull request as draft June 22, 2020 14:58
@rating89us rating89us closed this Oct 3, 2020
@rating89us
Copy link
Contributor Author

See #3128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rating89us