Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuccessfulTxDialog: add View progress button #3208

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

rating89us
Copy link
Contributor

@rating89us rating89us commented Nov 4, 2020

Closes #2148

Main changes:

  • SuccessfulTxDialog: add View progress (secondary) button
  • History: auto collapse tx item if there is a single result
  • History: clean searchInput + list of collapsed txs when closing page
  • History: add FontAwesome icons for txs with Pending and Failed states
  • History: Display Pending and Failed states to the right of "Sent" and "Received" labels

@selsta
Copy link
Collaborator

selsta commented Nov 4, 2020

I would make the "View progress" button secondary color.

@rating89us
Copy link
Contributor Author

updated

@xiphon
Copy link
Collaborator

xiphon commented Nov 14, 2020

  • Main: add appWindow.lastSentTransaction, which stores txid and destination address of the last sent transaction

Just wait till monero-project/monero#7020 gets merged.

@rating89us
Copy link
Contributor Author

rating89us commented Nov 30, 2020

monero-project/monero#7020 has been merged.

I tried to update my code, but I still can't get address of pending transactions.

destinations of pending transactions are returning "" instead of "amount + address".

@selsta
Copy link
Collaborator

selsta commented Nov 30, 2020

Did you set the monero submodule to master? It is only merged to master, the submodule is on v0.17.1.5 tag.

@rating89us
Copy link
Contributor Author

No, I haven't. How can I do it?

@rating89us
Copy link
Contributor Author

rating89us commented Nov 30, 2020

nevermind, I updated the file manually in my monero folder and it's working now.
Thanks

@selsta
Copy link
Collaborator

selsta commented Nov 30, 2020

cd monero
git fetch
git checkout master
cd ..
MANUAL_SUBMODULES=1 make -j4

@rating89us
Copy link
Contributor Author

ready for review

pages/History.qml Outdated Show resolved Hide resolved
pages/History.qml Outdated Show resolved Hide resolved
pages/History.qml Outdated Show resolved Hide resolved
pages/History.qml Outdated Show resolved Hide resolved
pages/History.qml Outdated Show resolved Hide resolved
pages/History.qml Outdated Show resolved Hide resolved
@selsta
Copy link
Collaborator

selsta commented Dec 10, 2020

There seems to be an issue here. I had this in my logs:

2020-12-10 23:45:34.691	W Qt Quick Layouts: Polish loop detected. Aborting after two iterations.

The layout was also bugged. Fixed itself after resizing the window.

Screenshot 2020-12-11 at 00 45 44

@selsta
Copy link
Collaborator

selsta commented Apr 24, 2021

Seems like this layout issue exists without this patch too. Guess we can merge this.

@luigi1111 luigi1111 merged commit c11e32f into monero-project:master Apr 24, 2021
@rating89us rating89us deleted the patch-63 branch April 24, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise send flow visuals
4 participants