Receive: selected address details on top; click on QR code to ampliate; click on description to edit; display full address; use standard button for create new address

[rating89us]

closes #2610

Changes:

• Selected address details on top (QR code, address #, description, full address).
• Left click on QR code: increase/decrease QR code size
• Right click on QR code: display "Save as Image" option
• Click on description: edit description
• Display full address
• Click on full address: copy address to clipboard
• Removed "Save as image" button
• Display last created address first on addresses list
• Create new address: use standard (orange) button; move to the top.

[selsta]

Removed "Save as image" button

Why? This can be useful. At least add it to the context menu when right clicking on the QR code. Otherwise looks good.

[rating89us]

At least add it to the context menu when right clicking on the QR code.

Done

[selsta]

One thing I'm not sure yet is that opening the page always selects the latest subaddress and also that the sort order is reverse (newest to oldest).

I kinda makes sense but I found it a bit confusing at first.

[rating89us]

opening the page always selects the latest subaddress

Instead of displaying a QR code + address when opening the page, we could display a question:

• Receiving from someone you received before? Select an address from the list.
• Receiving from a new person? Click on Create new address button

Or we don't display any QR code + address and just display the addresses list.

[rating89us]

Here is an example of what I meant on the comment above.
With this UI we educate users that every entity we're receiving from should have its own receiving address in the wallet.
We could also create options in Settings > Interface: Always create a new address when opening Receive page" and "Always display address list when opening Receive page").

[selsta]

I don't know yet, I don't like the idea of having a separate page and something when clicking on "Receive", it feels a bit clunky. Though I don't have a different suggestion currently. Maybe for this PR we can keep undo

One thing I'm not sure yet is that opening the page always selects the latest subaddress and also that the sort order is reverse (newest to oldest).

and then the other changes can be done later when this is merged so that we don't keep this PR stuck.

[selsta]

Intentional? I think it looks better centered.

[rating89us]

No, I'm trying to fix the width of these two lines (address and label) for Windows, but removed the center alignment.

[rating89us]

fixed your comments and added tooltips to label and address

[selsta]

Please squash.

[rating89us]

I'm trying to fix the center alignment on windows, but could't do it. Do you have any ideas?

[selsta]

Which Qt version?

[rating89us]

windows 7 GUI 0.17.2.2-83-g3acc24ea (Qt 5.15.2)

[selsta]

Weird, I don't have this on Mac with the same Qt version.

[selsta]

@rating89us try https://doc.qt.io/qt-5/qml-qtquick-text.html#horizontalAlignment-prop

also play around with wrap mode, layout.fillWidth: true, etc.

[rating89us]

fixed