Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2pool: add more detailed failure message, fix crash #4147

Merged
merged 2 commits into from
Aug 17, 2023
Merged

p2pool: add more detailed failure message, fix crash #4147

merged 2 commits into from
Aug 17, 2023

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Apr 9, 2023

No description provided.

@selsta selsta force-pushed the p2pool-error-logs branch 2 times, most recently from de4ec50 to 973fccf Compare April 9, 2023 01:56
@selsta selsta marked this pull request as draft April 9, 2023 02:36
@selsta selsta marked this pull request as ready for review April 9, 2023 02:51
@plowsof
Copy link
Contributor

plowsof commented Apr 9, 2023 •
edited
Loading

with this PR + discontinued p2pool URL's + hashes: Binary is not available ✔️
URL's of the latest p2pool + incorrect hashes: Hash verification failed ✔️
place monero-wallet-gui into a dir with no write access chmod -w dirname/: Try starting the program with administrator privileges ✔️
trying with my internet connection off: the monero-wallet-gui crashes after clicking "ok" on the install prompt 😄

2023-04-09 13:54:53.780	D Failed to connect to github.com:443
Segmentation fault (core dumped)

finally, with this PR + master: p2pool installs and runs perfectly ✔️

edit* confirming that this patch does not cause the crash above (happens with master) closes #4136

@selsta selsta changed the title p2pool: add more detailed failure message p2pool: add more detailed failure message, fix crash Apr 9, 2023
@selsta
Copy link
Collaborator Author

selsta commented Apr 13, 2023 •
edited
Loading

I added the change to the wrong commit :/ Will fix. Done.

@luigi1111 luigi1111 merged commit 866a7b3 into monero-project:master Aug 17, 2023
@selsta selsta deleted the p2pool-error-logs branch August 17, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plowsof plowsof plowsof approved these changes

@hinto-janai hinto-janai hinto-janai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@selsta @plowsof @hinto-janai @luigi1111