Update docs #2083
Update docs #2083
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks fro transferring to a single PR. The normal approach in this case is to squash but from the other conversation i take you prefer to have multiple commits for these changes. In past we usually squashed multiple commits changing a single file, but if he luigi is ok with multiple commits, ok for me.
I would keep the new changes consistent with the already existent structure. |
plowsof
force-pushed
the
update_docs
branch
2 times, most recently
from
4cc399d
to
a0ee981
Compare
plowsof
force-pushed
the
update_docs
branch
7 times, most recently
from
a983691
to
9bafcd2
Compare
plowsof
force-pushed
the
update_docs
branch
2 times, most recently
from
1ed20bd
to
294b54d
Compare
There was a problem hiding this comment.
@plowsof I would freeze the number of issues that will be solved in this PR, so that it can be reviewed and finally merged. I think it's getting to a state where more and more stuff is added here when new issues are opened, but that will result in the pr never getting merged and constant re-reviewing.
I suggest to not add any more commits to this pr and to have it reviewed. if more issues arise related to these docs, a new WIP pr can be opened and based on this one. I would keep as a general rule that if a dense PR is already reviewed/approved, better leave it as it is and open a new PR for additional commits.
erciccione
moved this from Review Needed
to Ready for merge
in monero-site: PR workflow
closes #2022
closes #2026
closes #1842
closes #1528
closes #2075
closes #2084
closes #2021
closes #2089
closes #2093
closes #2098
Note: set_log_level / categories are not documented in wallet rpc - but they are in daemon rpc -i think it would be best to list the commands in wallet rpc index but simply link people to the description like this , then if something is updated, it only has to be set in one place.
add_aux_pow is a wip but should not block this PR