New 404 page #956
Merged
New 404 page #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lafudoci
pushed a commit
to Lafudoci/monero-site
that referenced
this pull request
May 1, 2020
- remove cryptopia (monero-project#956) - add 'print-ted' (monero-project#959) - add 'bitci.com' (monero-project#962) - edit 'BITEXBOOK' (monero-project#961)
Lafudoci
pushed a commit
to Lafudoci/monero-site
that referenced
this pull request
May 1, 2020
Add and remove merchants Closes monero-project#956, monero-project#959, monero-project#962, and monero-project#961 See merge request monero-project/monero-site!1090
|
I'd like to have better text under the 404 that's Monero-related somehow. Don't hold the PR for this though. |
|
Definitely a beautiful PR, but I agree with @SamsungGalaxyPlayer. 404Page not found Usually we want Monero to break links. Not this time though. |
404Link not found ( perhaps it values privacy ) |
|
No problem in holding the PR, this is not urgent. I'm ok changing the text, but i would prefer to have it on a single line: 404 |
|
If there are no more ideas, i would suggest to use a slightly edited version of @jerrimus' phrase:
|
Removed the '404' folder with its content and created a new '404.html' file in the root directory, added some specific css and slighlty edited the 'error' layout.
|
|
SamsungGalaxyPlayer
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old javascript-based 404 page is broken and the standard page from nginx shows up in case of a 404 error.
Removed the '404' folder with its content and created a new
404.htmlfile in the root directory, added some specific css and slighlty edited the 'error' layout.@binaryFate might be necessary to slighly tweak the nginx .conf file to have this working properly. See https://jekyllrb.com/tutorials/custom-404-page/#hosting-on-nginx-server
Preview: