unit_tests: fix strtoul unit test

monero-project · Mar 7, 2024 · 25a4793 · 25a4793
1 parent 68e40ea
commit 25a4793
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/tests/unit_tests/epee_utils.cpp b/tests/unit_tests/epee_utils.cpp
@@ -1843,47 +1843,39 @@ TEST(parsing, strtoul)
   const char* p;
   const char* endp;
 
-  errno = 0; // Some libc's only set errno on failure, some set it to 0 on success
-
   p = "0";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(0, ul);
   EXPECT_EQ(p + 1, endp);
 
   p = "000000";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(0, ul);
   EXPECT_EQ(p + 6, endp);
 
   p = "1";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(1, ul);
   EXPECT_EQ(p + 1, endp);
 
   p = "0q";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(0, ul);
   EXPECT_EQ(p + 1, endp);
 
   p = "    \t   0";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(0, ul);
   EXPECT_EQ(p + 9, endp);
 
   p = "q";
   endp = nullptr;
   ul = std::strtoul(p, const_cast<char**>(&endp), 10);
-  EXPECT_EQ(0, errno);
   EXPECT_EQ(0, ul);
   EXPECT_EQ(p, endp);