Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Wagner attack' in Monero multisig #7830

Closed
erciccione opened this issue Aug 4, 2021 · 5 comments
Closed

'Wagner attack' in Monero multisig #7830

erciccione opened this issue Aug 4, 2021 · 5 comments

Comments

@erciccione
Copy link
Contributor

Monero's multisignature implementation is vulnerable to a Wagner attack: if multiple signatures are constructed for a given address, and the wagner attack is executed, then the attacker can learn the private key shares of other participants.

We (Haveno) had talks with @luigi1111, @SarangNoether, @moneromooo-monero and @UkoeHB about it. Looks like the change needed to fix the vulnerability would be quite invasive so a deeper look into the problem is needed.

@SarangNoether suggests to implement MRL-0009. @moneromooo-monero gave his availability for the coding part if somebody provide him with python code to refactor into C++. We need a cryptographer willing to look into the issue and provide mooo with the info he needs.

Haveno is happy to provide resources to fix the vulnerability and we already opened an issue to keep track of progresses: haveno-dex/haveno#103. As you can see, the issue has a bounty, but we could provide more resources if necessary.

@AAH20
Copy link

AAH20 commented Aug 27, 2021

Still no one solved it ?
Here is the solution :

Digital Envelopes , signatures implementation along with MRL-009 , check the internet engineering task force latest rfc9101 to have a sufficient knowledge of how a secure communication channel should be specially in form of secure implementation of apis.

@UkoeHB
Copy link
Contributor

UkoeHB commented Aug 27, 2021

@AAH20 We already have a solution (MRL-0009), it just requires someone to implement it.

Transmitting data between multisig participants securely is out-of-scope for this issue.

@AAH20
Copy link

AAH20 commented Aug 27, 2021

@UkoeHB okay lets see who can implement that and also take a look at my new issue #7896 and feel free to share your opinion.

@selsta
Copy link
Collaborator

selsta commented Mar 16, 2022

#8113

@johnnyluo
Copy link

given #8149 has been merged , believe this one has been fixed, correct?

@selsta selsta closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants