wallet: fix pre-rct cold wallet signing not splitting change #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, wait a bit, I'll replace with some more stuff (and bump version) |
|
Hate to be this guy, but the past participle of 'to split' is 'split' rather than 'splitted'. English makes no sense... |
Re-creating the transaction on the cold wallet was not splitting the change, causing the transaction to be rejected by the network. This worked on testnet since amounts do not have to be split. Also add selected_transfers, which can now be saved since they're size_t rather than iterators. This allows the view wallet to properly set the sent outputs as spent and update balance. Bump transfer file version numbers to match.
moneromooo-monero
force-pushed
the
cold-signing-fix
branch
from
724960c
to
31abac4
Compare
|
done |
|
split, splat, splut ? |
|
Hmm, that's used in many other places, so it'll have to stay that way. |
moneroexamples
added a commit
to moneroexamples/onion-monero-blockchain-explorer
that referenced
this pull request
Oct 26, 2016
Not as trustworthy as this is in the view wallet, the one that's considered compromised.
moneromooo-monero
force-pushed
the
cold-signing-fix
branch
from
39267ef
to
069d688
Compare
|
Small update, I'd forgot to add a file to the commit (the one that actually logs the tx). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating the transaction on the cold wallet was not splitting
the change, causing the transaction to be rejected by the network.
This worked on testnet since amounts do not have to be split.