New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet2: fix double counting outs if more than one pubkey #3985

Merged
merged 1 commit into from Jul 3, 2018

Conversation

3 participants
@moneromooo-monero
Contributor

moneromooo-monero commented Jun 11, 2018

No description provided.

@moneromooo-monero

This comment has been minimized.

Show comment
Hide comment
@moneromooo-monero

moneromooo-monero Jun 11, 2018

Contributor

Wait. That's wrong, it just works by accudent on that test case. Will fix better.

Contributor

moneromooo-monero commented Jun 11, 2018

Wait. That's wrong, it just works by accudent on that test case. Will fix better.

@moneromooo-monero moneromooo-monero changed the title from wallet2: fix double counting subaddress outs if more than one pubkey to wallet2: fix double counting outs if more than one pubkey Jun 11, 2018

Show outdated Hide outdated src/wallet/wallet2.cpp Outdated
@stoffu

stoffu approved these changes Jun 28, 2018

@fluffypony

Reviewed

@fluffypony

Reviewed

@fluffypony fluffypony merged commit 58cceaa into monero-project:master Jul 3, 2018

fluffypony added a commit that referenced this pull request Jul 3, 2018

Merge pull request #3985
58cceaa wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)

thaerkh added a commit to masari-project/masari that referenced this pull request Jul 5, 2018

jcktm added a commit to loki-project/loki that referenced this pull request Jul 6, 2018

Fix double-counting of ins/outs on web wallet transactions
Transactions from the web wallet could have a duplicated public key,
which caused the Monero wallet to double-count ins and outs.

Fixed by applying upstream patch (Monero PR monero-project#3985).

GoPrivatePay pushed a commit to GoPrivatePay/PrivatePay that referenced this pull request Jul 6, 2018

@fireice-uk fireice-uk referenced this pull request Jul 6, 2018

Merged

fix tx double scan #38

ZuccBucc added a commit to zuccbucc-project/zuccbucc that referenced this pull request Jul 7, 2018

@andrepatta andrepatta referenced this pull request Aug 20, 2018

Merged

Electroneum v2.1.1.0 #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment