Update submodules

[anonimal]

Resolves #3990.

[anonimal]

Win64 build fails with:

[ 90%] Linking CXX executable ../../bin/monero-wallet-rpc.exe
make[3]: Leaving directory '/home/vagrant/slave/monero-static-win64/build/build/release'
make[2]: Leaving directory '/home/vagrant/slave/monero-static-win64/build/build/release'
make[1]: Leaving directory '/home/vagrant/slave/monero-static-win64/build/build/release'
../../external/unbound/libunbound.a(net_help.c.obj):net_help.c:(.text+0x1668): undefined reference to `__imp_CertOpenStore'
../../external/unbound/libunbound.a(net_help.c.obj):net_help.c:(.text+0x168c): undefined reference to `__imp_CertEnumCertificatesInStore'
../../external/unbound/libunbound.a(net_help.c.obj):net_help.c:(.text+0x18da): undefined reference to `__imp_CertCloseStore'
collect2.exe: error: ld returned 1 exit status
make[3]: *** [src/wallet/CMakeFiles/wallet_rpc_server.dir/build.make:133: bin/monero-wallet-rpc.exe] Error 1
make[2]: *** [CMakeFiles/Makefile2:2282: src/wallet/CMakeFiles/wallet_rpc_server.dir/all] Error 2
make[1]: *** [Makefile:129: all] Error 2
make: *** [Makefile:119: release-static-win64] Error 2

[MaxXor]

Why do you use the latest RapidJson from master instead of stable version?

[jagerman]

Win64 build fails with: [snip]

Apparently with the newest unbound there is a need to link crypt32. You could hack that into the MINGW-specific EXTRA_LIBRARIES in the root CMakeLists.txt to get the compilation to work, but that doesn't seem like the right place.

[anonimal]

Why do you use the latest RapidJson from master instead of stable version?

@MaxXor please do your "due diligence"

8a6c081
https://github.com/Tencent/rapidjson/releases
Tencent/rapidjson#1282
Tencent/rapidjson#1265

You could hack that into the MINGW-specific EXTRA_LIBRARIES in the root CMakeLists.txt to get the compilation to work, but that doesn't seem like the right place.

Thanks @jagerman. CMakeLists.txt will most certainly be the right place as that's the exact reason why we have a monero branch to work with. You can PR to https://github.com/monero-project/unbound/tree/monero or I'll get to it before monero 0.12.4.0.

[moneromooo-monero]

I did not review the changes to the trees, but I checked unbound and miniupnpc are moved to a merge commit signed by fluffypony, and rapidjson is moved to a commit which exists in the upstream Tencent tree.

[anonimal]

@luigi1111 was this resolved though?... #4105 (comment)