CONTRIBUTING: mention not changing spelling/typoes in code #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyc
reviewed
Dec 3, 2018
CONTRIBUTING.md
Outdated
| @@ -19,7 +19,8 @@ posted to #monero-dev on irc.freenode.net). | |||
|
|
|||
| Patches should be self contained. A good rule of thumb is to have | |||
| one patch per separate issue, feature, or logical change. Also, no | |||
| other changes, such as random whitespace changes or reindentation. | |||
| other changes, such as random whitespace changes reindentation, | |||
There was a problem hiding this comment.
Should have a comma in "changes, reindentation"
moneromooo-monero
force-pushed
the
Csp
branch
from
1968430
to
ea85de4
Compare
stoffu
approved these changes
Dec 3, 2018
luigi1111
added a commit
that referenced
this pull request
Dec 31, 2018
ea85de4 CONTRIBUTING: mention not changing spelling/typoes in code (moneromooo-monero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.