-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor get_payments for future separation from wallet2 #5598
Refactor get_payments for future separation from wallet2 #5598
Commits on May 31, 2019
-
wallet2: new function that gets payments starting at min_height
The original function gets payments starting at min_height+1. Though this is unexpected behaviour, it shall remain the default in order to maintain backwards compatibility.
Configuration menu - View commit details
-
Copy full SHA for 3104f4c - Browse repository at this point
Copy the full SHA 3104f4cView commit details -
wallet2: use const payment_container& in get_payments_min_height_incl…
…usive() This makes it compatible to m_payments' type. m_payments is used when called from get_payments().
Configuration menu - View commit details
-
Copy full SHA for 1a82ad0 - Browse repository at this point
Copy the full SHA 1a82ad0View commit details
Commits on Jun 1, 2019
-
wallet2: new function that gets out-payments starting at min_height
The original function gets out-payments starting at min_height+1. Though this is unexpected behaviour, it shall remain the default in order to maintain backwards compatibility. The approach is analogous to the changes in commit:3104f4cb.
Configuration menu - View commit details
-
Copy full SHA for b476443 - Browse repository at this point
Copy the full SHA b476443View commit details -
wallet2: default get_payments functions correctly regard min_height
It was decided to ditch backwards compatibility (mentioned in commit:3104f4cb & commit:b4764435) in favor of a clean implementation going forward.
Configuration menu - View commit details
-
Copy full SHA for 2e2e1d9 - Browse repository at this point
Copy the full SHA 2e2e1d9View commit details
Commits on Jun 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0c43135 - Browse repository at this point
Copy the full SHA 0c43135View commit details -
Configuration menu - View commit details
-
Copy full SHA for e65fd7f - Browse repository at this point
Copy the full SHA e65fd7fView commit details
Commits on Jun 5, 2019
-
wallet2: substituted "min_height" for "threshold" and reverted to ori…
…ginal get_payments logic Dictionaries define **minimum** as "the least quantity or amount possible", while threshold is "the point that must be exceeded to begin producing a given effect".
Configuration menu - View commit details
-
Copy full SHA for 0710b8f - Browse repository at this point
Copy the full SHA 0710b8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e32ff8f - Browse repository at this point
Copy the full SHA e32ff8fView commit details
Commits on Jun 12, 2019
-
wallet2: renamed "threshold" back to "min_height"
- as per hyc's explanation that renaming words was out of scope
Configuration menu - View commit details
-
Copy full SHA for c0eed5b - Browse repository at this point
Copy the full SHA c0eed5bView commit details -
unit_tests: reduced indents from eight to two
- as per moneromoo's hint that the project typically used 2 or 4
Configuration menu - View commit details
-
Copy full SHA for 0b573e3 - Browse repository at this point
Copy the full SHA 0b573e3View commit details