cmake: allow custom openssl path on macOS #6691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
reviewed
Jul 28, 2020
| @@ -426,7 +426,7 @@ endif () | |||
|
|
|||
| if (APPLE AND NOT IOS) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=x86-64 -fvisibility=default -std=c++11") | |||
| if (NOT OpenSSL_DIR) | |||
There was a problem hiding this comment.
Does this fetch and install OpenSSL automatically? That seems odd to have in the Monero build process.
There was a problem hiding this comment.
If OPENSSL_ROOT_DIR is not set manually it will check if openssl is installed with brew and get its path. Nothing gets fetched or downloaded.
moneromooo-monero
approved these changes
Aug 11, 2020
TheCharlatan
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to specify a custom openssl dir by using
-DOPENSSL_ROOT_DIRon macOS.Tested with gitian, works as expected now. The old
OpenSSL_DIRwas probably a typo.