Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.17] net_node: add --ban-list option #6961

Merged
merged 1 commit into from Nov 4, 2020

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Nov 2, 2020

No description provided.

@sumogr
Copy link
Contributor

sumogr commented Nov 2, 2020

IMO add a permanent ban option something like ban -1 <IP> which will ban an ip at max time_t limit and only those IPs will be exported to that file. Also make that file to be re-read upon each daemon restart to automatically ban these "asshole" ips.
I did that somewhere else i can port it if you wish (or of course you may do it yourself its simple)

@selsta
Copy link
Collaborator Author

selsta commented Nov 2, 2020

You can save a ban list at any place and add ban-list=/path/to/list.txt and it will permanently get read on startup.

@sumogr
Copy link
Contributor

sumogr commented Nov 2, 2020

You can save a ban list at any place and add ban-list=/path/to/list.txt and it will permanently get read on startup.

true it works as well
however i insist on my opinion of banning "asshole" nodes beyond the 2 days or so ban limit
maybe combine it with moo's 6944

@selsta
Copy link
Collaborator Author

selsta commented Nov 2, 2020

Not sure what you mean. This bans them for basically unlimited time.

@sumogr
Copy link
Contributor

sumogr commented Nov 2, 2020

Not sure what you mean. This bans them for basically unlimited time.

block_host(*parsed_addr, std::numeric_limits<time_t>::max());
my bad i've just seen it ;)

@luigi1111 luigi1111 merged commit 0be71bc into monero-project:release-v0.17 Nov 4, 2020
@selsta selsta deleted the ban-list-v0.17 branch November 4, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants