Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Install and publish stripped binaries for Depends #7704

Closed
wants to merge 1 commit into from

Conversation

mj-xmr
Copy link
Contributor

@mj-xmr mj-xmr commented Apr 30, 2021

Using CMake's special install/strip target, which strips the final binaries while installing them into the installation directory. The directory is pointed by the CMAKE_INSTALL_PREFIX variable.

The below changes were measured for the unpacked artifacts, so nearest to the end-user's space consumption.

Target Previous Current Change
Win64 63.7 MB 32.9 MB -48.35%
x86_64 Linux 55.8 MB 44.4 MB -20.43%
Cross-Mac 47.3 MB 41.6 MB -12.05%

@selsta
Copy link
Collaborator

selsta commented Apr 30, 2021

Hmm, here we will also have the same issue as we discussed with release binaries :/ These CI bins are mostly used if someone has a bug so stripping them will also be suboptimal in case they have to use gdb.

Seeing that Github storage is free anyway I would leave them like it is.

With #7683 it will be easy to strip them anyway if someone wants to do that locally.

@mj-xmr mj-xmr marked this pull request as draft April 30, 2021 13:16
@mj-xmr
Copy link
Contributor Author

mj-xmr commented May 1, 2021

For the record: it's not about Github storage here, but about showing how much one can spare with the binaries, delivered to the end users on their hard drives.

@selsta also pointed out, that even the released binaries are sometimes used for debugging.
asymptotical OTOH said, that we could be delivering stripped binaries to the end user, but on demand (for debugging) the user could be supplied with the symbols themselves as a separate package. I confirm from my experience, that such a technique is being practised in the industry.

I'll leave this PR open in draft mode for now, so that everybody can learn and after a while, I will close it.

@mj-xmr mj-xmr closed this May 1, 2021
@mj-xmr mj-xmr reopened this May 1, 2021
@hyc
Copy link
Collaborator

hyc commented May 1, 2021

IMO, moving debug symbols into a separate package is just added hassle. An extra hoop for users to jump through before we can get meaningful diagnostics from a crash.

@mj-xmr mj-xmr closed this May 25, 2021
@mj-xmr mj-xmr deleted the cmake-install-strip branch July 15, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants