Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci make single threaded after failure #7827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mj-xmr
Copy link
Contributor

@mj-xmr mj-xmr commented Aug 3, 2021

If the parallel version of make fails, running make in single threaded mode with the same parameters as before. This brings no side effects if the parallel version succeeds, but if it fails, then it makes it much more clearer what the error was. This is because for the single threaded version of make the first error that occurred, will be visible at the very bottom of the log, instead of being cluttered with potentially many unrelated warnings below the actual error.

@mj-xmr mj-xmr changed the title Ci make single threaded after failure take2 Ci make single threaded after failure Aug 3, 2021
@mj-xmr mj-xmr marked this pull request as draft August 3, 2021 06:22
@mj-xmr mj-xmr force-pushed the ci-make-single-threaded-after-failure-take2 branch from cf13674 to 95d0a77 Compare August 3, 2021 06:24
@mj-xmr mj-xmr marked this pull request as ready for review August 3, 2021 06:39
@mj-xmr mj-xmr force-pushed the ci-make-single-threaded-after-failure-take2 branch from 95d0a77 to 508dbe6 Compare September 25, 2021 09:27
@selsta
Copy link
Collaborator

selsta commented Oct 15, 2021

I feel this makes it a bit more complicated for minor gain, but that's my personal preference. (it's easy to just search for error:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants