common: update sha256sum to use OpenSSL 3.0 API, add test cases #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
suggested changes
May 17, 2022
selsta
force-pushed
the
openssl
branch
2 times, most recently
from
4fe1f77
to
9444da5
Compare
jeffro256
reviewed
May 17, 2022
jeffro256
approved these changes
May 17, 2022
hyc
reviewed
May 17, 2022
selsta
force-pushed
the
openssl
branch
2 times, most recently
from
9060dd7
to
cbdf061
Compare
As of OpenSSL 3.0, `SHA256_Init`, `SHA256_Update`, and `SHA256_Final` are deprectaed in favor of the higher-level `EVP_*` class of functions. This causes compiler warnings, and sooner or later, will cause build errors as these functions are excluded from distro headers. Also add some documentation.
hyc
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by @jeffro256 and from IRC, continued from #8322. This unfortunately ended in a lot of discussion so I wanted to open this so that we can just move on.