wallet: background sync with just the view key [release] #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
j-berman
force-pushed
the
background-sync
branch
2 times, most recently
from
7d6cb91
to
8bf1b87
Compare
j-berman
force-pushed
the
background-sync
branch
from
8bf1b87
to
a5c21e2
Compare
j-berman
force-pushed
the
background-sync
branch
2 times, most recently
from
2fc25b8
to
772b594
Compare
j-berman
force-pushed
the
background-sync
branch
from
dc4d69b
to
a37de1d
Compare
j-berman
changed the title
j-berman
force-pushed
the
background-sync
branch
from
29f8a1b
to
31c5245
Compare
j-berman
changed the title
j-berman
force-pushed
the
background-sync
branch
from
8daaf28
to
8a651d4
Compare
j-berman
force-pushed
the
background-sync
branch
from
7ef7447
to
8f4187e
Compare
j-berman
force-pushed
the
background-sync
branch
from
8f4187e
to
aff1abf
Compare
- When background syncing, the wallet wipes the spend key from memory and processes all new transactions. The wallet saves all receives, spends, and "plausible" spends of receives the wallet does not know key images for. - When background sync disabled, the wallet processes all background synced txs and then clears the background sync cache. - Adding "plausible" spends to the background sync cache ensures that the wallet does not need to query the daemon to see if any received outputs were spent while background sync was enabled. This would harm privacy especially for users of 3rd party daemons. - To enable the feature in the CLI wallet, the user can set background-sync to reuse-wallet-password or custom-background-password and the wallet automatically syncs in the background when the wallet locks, then processes all background synced txs when the wallet is unlocked. - The custom-background-password option enables the user to open a distinct background wallet that only has a view key saved and can be opened/closed/synced separately from the main wallet. When the main wallet opens, it processes the background wallet's cache. - To enable the feature in the RPC wallet, there is a new `/setup_background_sync` endpoint. - HW, multsig and view-only wallets cannot background sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8619