p2p: fix exclusive node DNS resolution for certain hosts #8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I'm currently confused about is running your test without your fix makes the NA_HOST_AND_PORT_TEST("bar:29080", "bar", "29080"); // Issue https://github.com/monero-project/monero/issues/8633test succeed. Shouldn't it fail according to the bug? Edit: Ignore, the bug wasn't in |
selsta
approved these changes
Nov 17, 2022
|
Yes, as @selsta points out, the bug is in |
vtnerd
suggested changes
Nov 17, 2022
|
@vtnerd did this last commit cover everything? |
|
@jeffro256 looks good, please squash |
Fixes monero-project#8633. The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character. @vtnerd comments 1 clear up 2nd conditional statement
jeffro256
force-pushed
the
address_host_port_bar
branch
from
d6bc318
to
faaf2af
Compare
selsta
approved these changes
Nov 18, 2022
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Nov 21, 2022
Unrelated, but similar code-wise to monero-project#8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Nov 22, 2022
Unrelated, but similar code-wise to monero-project#8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Nov 22, 2022
Unrelated, but similar code-wise to monero-project#8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
niklasha
pushed a commit
to niklasha/monero
that referenced
this pull request
Mar 18, 2024
Unrelated, but similar code-wise to monero-project#8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8633. The function
append_net_addressdid not parse hostname + port addresses (e.g.bar:29080) correctly if the hostname did not contain a.character.