Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialization: remove unused function dump_json #8735

Merged
merged 1 commit into from
Apr 26, 2023
Merged

serialization: remove unused function dump_json #8735

merged 1 commit into from
Apr 26, 2023

Conversation

jeffro256
Copy link
Contributor

No description provided.

@selsta
Copy link
Collaborator

selsta commented Apr 5, 2023

@jeffro256 Can you double check if the mining RPC test fail is unrelated?

AssertionError: {'error': {'code': -32701, 'message': 'Params is not an object'}, 'id': 0, 'jsonrpc': '2.0'}

@jeffro256
Copy link
Contributor Author

jeffro256 commented Apr 5, 2023 •
edited
Loading

That error should be caused by the reverted change: b67e931. I'll rebase for good measure

selsta
selsta approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I remember again.

@luigi1111 luigi1111 merged commit 28e43b1 into monero-project:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta approved these changes

@UkoeHB UkoeHB UkoeHB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffro256 @selsta @UkoeHB @luigi1111