Set SSL SNI even when server verification is disabled #8899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
reviewed
Jun 15, 2023
| @@ -497,6 +497,13 @@ void ssl_options_t::configure( | |||
| const std::string& host) const | |||
| { | |||
| socket.next_layer().set_option(boost::asio::ip::tcp::no_delay(true)); | |||
| { | |||
There was a problem hiding this comment.
I don't like the superfluous braces, but besides that, looks good to me!
jeffro256
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found while running LWS, but I don't see a reason to not fix this upstream.
Someone was trying a connection to a cloudflare site (webhooks) - which requires SSL SNI usage to work correctly - and combined it with a call to not verify the cloudflare server. It took me a while to track down the issue: we only set SNI when verifying the server certificate. There's no reason for this, it can be used with or without verifying the certificates.